This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][Python] gdbpy_frame_stop_reason_string bug

On Mon, Oct 24, 2011 at 7:13 PM, Eli Zaretskii <> wrote:
>> From: Kevin Pouget <>
>> Date: Mon, 24 Oct 2011 18:27:01 +0200
>> Cc: Pedro Alves <>,,,
>> ? ? ? Tom Tromey <>
>> ping, you might have missed this thread Eli
> Yes, sorry.
>> +All the conditions after this alias are considered errors;
> Hmm... ?This table is preceded by this text:
> ?@defun Frame.unwind_stop_reason ()
> ?Return an integer representing the reason why it's not possible to find
> ?more frames toward the outermost frame. ?Use
> ?@code{gdb.frame_stop_reason_string} to convert the value returned by this
> ?function to a string. The value can be one of:
> So "conditions after this alias" seems inappropriate in the list that
> follows, because we are not describing conditions or aliases. ?Can you
> rephrase this to be consistent with the rest of the list.

I'm not sure about you see wrong with "alias". We could replace it
with "reference" (like the & operator in C++, but also used in Python
and Java), but it sounds more or less the same to me.

What do you think about:
"Stop reasons greater or equal to this value/alias/reference"

> And why is it important that the value is an alias for another?

it's important because it's not a distinct value as the other ones, so
> frame_stop_reason_string(UNWIND_FIRST_ERROR) == frame_stop_reason_string(UNWIND_UNAVAILABLE)
is True, which might be counter-intuitive if you don't know that
UNWIND_FIRST_ERROR is an alias/reference

>> +abnormal stack termination. ?Current value is gdb.FRAME_UNWIND_UNAVAILABLE. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This should be in @code{}.

I'll change it

> Okay with these changes.

Thanks for your time,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]