This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:")

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Ulrich Weigand <uweigand at de dot ibm dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 11 Oct 2011 22:06:33 +0200
Subject: Re: [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:")
References: <20111010202141.GA27651@host1.jankratochvil.net> <201110111906.p9BJ6h8k023538@d06av02.portsmouth.uk.ibm.com>

On Tue, 11 Oct 2011 21:06:43 +0200, Ulrich Weigand wrote:
> I just noticed that this still causes spurious warnings since the
> condition is incorrect: we want to skip the warning if the parent's
> CRC matches the (potential) debuginfo *file* CRC, not the CRC the
> debuginfo is supposed to have.

I agree, sorry, I admit I did not try to test it, I should have asked for
a test.


Thanks,
Jan

References:
- Re: [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remote:"
  - From: Jan Kratochvil
- [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:")
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]