This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[committed]: [patch] Skip kill-after-signal.exp if hw single-step is not supported
- From: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 18 Sep 2011 10:41:37 +0800
- Subject: [committed]: [patch] Skip kill-after-signal.exp if hw single-step is not supported
- References: <4E259815.8080001@codesourcery.com> <201107201605.43767.pedro@codesourcery.com> <201107232247.p6NMlwVx029216@glazunov.sibelius.xs4all.nl> <4E414503.7080201@codesourcery.com> <20110918001057.GA11805@adacore.com>
On 09/18/2011 08:10 AM, Joel Brobecker wrote:
>> gdb/testsuite/
>>
>> * lib/gdb.exp (single_step_to_signal_handler_p): New.
>> * gdb.base/kill-after-signal.exp: Skip if target supports single step
>> to signal handler.
>
> No one commented on this patch.
>
> I only have minor comments, so pre-approved with those changes.
>
Joel, thanks for the review.
>
> Can you name the function "can_single_step_to_signal_handler" instead?
> I think it will be a little clearer what this function is about.
>
OK.
> Also, your comments, both in the function description as well as
> inside the function itself, are a little two wide. We have a soft-limit
> of 70 chars, which can be exceeded if it helps readability.
>
OK, I re-format comments a little bit to comply to 70-char limit.
Committed.
http://sourceware.org/ml/gdb-cvs/2011-09/msg00114.html
--
Yao (éå)