This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed]: [patch] Skip kill-after-signal.exp if hw single-step is not supported


On 09/18/2011 08:10 AM, Joel Brobecker wrote:
>> gdb/testsuite/
>>
>> 	* lib/gdb.exp (single_step_to_signal_handler_p): New.
>> 	* gdb.base/kill-after-signal.exp: Skip if target supports single step
>> 	to signal handler.
> 
> No one commented on this patch.
> 
> I only have minor comments, so pre-approved with those changes.
> 

Joel, thanks for the review.

> 
> Can you name the function "can_single_step_to_signal_handler" instead?
> I think it will be a little clearer what this function is about.
> 

OK.

> Also, your comments, both in the function description as well as
> inside the function itself, are a little two wide. We have a soft-limit
> of 70 chars, which can be exceeded if it helps readability.
> 

OK, I re-format comments a little bit to comply to 70-char limit.
Committed.

http://sourceware.org/ml/gdb-cvs/2011-09/msg00114.html

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]