This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
You forgot to copy a couple "the"s though. :-)> The past tense ("was executed") is better here. Copied your suggestion > directly. :)
Does the arm_displaced_step_fixup handler ever do more than just adjusting the PC for syscalls? I see there's a ->cleanup callback there that does some things with registers. If so, we'll need to do more than just adjusting the PC of the child. (A more general fix would run the fixup on the child too instead.)
Otherwise looks okay.
On Wednesday 14 September 2011 11:50:24, Yao Qi wrote:You have a spurious empty line here.> + regcache_write_pc (child_regcache, parent_pc); > + > + }
-- Yao (éå)
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |