This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target


On Thu, Sep 8, 2011 at 8:34 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote:
>> > From: Jan Kratochvil <jan.kratochvil@redhat.com>
>> > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
>>
>> Uh, that's wrong. ?The middle part if the target triplet is supposed
>> to be the hardware vendor. ?For i386/amd64 this is pretty much
>> meaningles, but attaching a new meaning to it would be a mistake.
>>
>> Fortunately, your diff doesn't really depend on this. ?But I think you
>> should adjust the comments in the code.
>
> The triple x86_64-x32-linux* is a reality in binutils, gcc etc., I believe if
> it should be changed GDB is not the place to start such change.
>
> And the comments should reflect the reality.
>
> OK to check it in as is?
>

I am using x86_64-x32-linux* for x32.  Instead, I
am using x86_64-*-linux* with sizeof (long) == 4.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]