Re: [RFA] Improve performance with lots of shared libraries

[Gary Benson <gbenson at redhat dot com>]

Tom Tromey wrote:
> >>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
> 
> Gary> While working on a new linker-debugger interface I took some
> Gary> time out to do a bit of profiling to see exactly where gdb is
> Gary> spending its time with inferiors that load a lot of shared
> Gary> libraries, and it turned out that the top 30% of the profile
> Gary> was update_section_map and the things it calls.
> 
> Nice.
> 
> I think this will solve a problem I had:
> 
>     http://sourceware.org/ml/gdb-patches/2011-03/msg00606.html

Oh, I think it will.  Nice!

> I have a couple nits.
> 
> Gary> +/* Nonzero if the location stopoed at is the shlib event breakpoint.  */
> 
> Typo, "stopped".
> 
> Gary> +static int
> Gary> +at_solib_event_breakpoint (struct execution_control_state *ecs)
> Gary> +{
> Gary> +  struct solib_event_breakpoint_helper_arg arg;
> Gary> +  arg.prev_pc = ecs->event_thread->prev_pc;
> 
> Blank line between declarations and code.

Cool, fixed.

Thanks,
Gary

-- 
http://gbenson.net/