This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

FYI: more cleanup fixes


I'm checking this in on the trunk.

One last round of cleanup fixes.

Built and regtested by the buildbot.

I neglected to mention in the last email: if anybody wants the latest
version of the plugin, just let me know.

Tom

2011-06-30  Tom Tromey  <tromey@redhat.com>

	* varobj.c (varobj_create): Call do_cleanups on early exit path.
	* valops.c (find_overload_match): Call do_cleanups on early exit
	path.
	* solib.c (solib_find): Call do_cleanups on early exit path.

Index: solib.c
===================================================================
RCS file: /cvs/src/src/gdb/solib.c,v
retrieving revision 1.148
diff -u -r1.148 solib.c
--- solib.c	17 Apr 2011 18:38:45 -0000	1.148
+++ solib.c	30 Jun 2011 19:26:24 -0000
@@ -254,6 +254,7 @@
   if (remote_filename_p (temp_pathname))
     {
       *fd = -1;
+      do_cleanups (old_chain);
       return temp_pathname;
     }
 
Index: valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.280
diff -u -r1.280 valops.c
--- valops.c	27 Jun 2011 19:21:50 -0000	1.280
+++ valops.c	30 Jun 2011 19:26:24 -0000
@@ -2585,6 +2585,7 @@
 	  if (*valp)
 	    {
 	      *staticp = 1;
+	      do_cleanups (all_cleanups);
 	      return 0;
 	    }
 	}
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.178
diff -u -r1.178 varobj.c
--- varobj.c	24 Jun 2011 19:47:37 -0000	1.178
+++ varobj.c	30 Jun 2011 19:26:24 -0000
@@ -580,6 +580,7 @@
          return a sensible error.  */
       if (!gdb_parse_exp_1 (&p, block, 0, &var->root->exp))
 	{
+	  do_cleanups (old_chain);
 	  return NULL;
 	}
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]