This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Remove write-only local variable sw_single_step_trap_p


On Tuesday 21 June 2011 06:39:11, Yao Qi wrote:
> Local variable sw_single_step_trap_p is not read in
> handle_inferior_event.  We can safely remove it.
> 
> It is somewhat obvious, and I'll check it in in 24 hours if no objection.

This is okay.  AFAICS, that variable became unused/unnecessary when
gdb was made to adjust the PC early with adjust_pc_after_break.
(I looked at 5.3's sources [circa 2002], to check how the
variable was used back then)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]