This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] win32: Lookup symbols in the EA Table by ordinal

From: Paul Bolle <pebolle at tiscali dot nl>
To: gdb-patches at sourceware dot org
Date: Wed, 15 Jun 2011 10:13:44 +0200
Subject: Re: [PATCH] win32: Lookup symbols in the EA Table by ordinal
References: <1307879815.1831.0.camel@t41.thuisdomein> <20110613183850.GA25400@ednor.casa.cgf.cx>

On Mon, 2011-06-13 at 14:38 -0400, Christopher Faylor wrote:
> This looks ok except for the unneeded reordering of the function.  I didn't see
> any reason to move ordbase or expdata.

0) Thanks for the review.

1) Moving ordbase and exp_funcbase was mainly a nitpick (which wouldn't
justify a separate patch): I prefer file parsing code to match the
structure of the file format it parses (wherever that is feasible). And
here the code is jumping around the PE format for no apparent reason.

Paul Bolle

References:
- [PATCH] win32: Lookup symbols in the EA Table by ordinal
  - From: Paul Bolle
- Re: [PATCH] win32: Lookup symbols in the EA Table by ordinal
  - From: Christopher Faylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]