This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/libiberty] Darwin has case-insensitive filesystems
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org
- Date: Tue, 14 Jun 2011 14:56:49 -0700
- Subject: Re: [RFA/libiberty] Darwin has case-insensitive filesystems
- References: <1308087182-26577-1-git-send-email-brobecker@adacore.com>
On Tue, Jun 14, 2011 at 2:33 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello,
>
> HFS+, the FS on Darwin, is case insensitive. So this patch adjusts
> filename_cmp.c to ignore the casing when comparing filenames on Darwin.
This is wrong as not all FSs are case insensitive. In fact HFS+ can
be case sensitive too. I think you need better check than just saying
all Darwin is case insensitive. This is just like using FAT32 on
Linux. In fact I think HAVE_DOS_BASED_FILE_SYSTEM is incorrect also
for NTFS as it can also be case sensitive.
Thanks,
Andrew Pinski