This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649)


On Friday 27 May 2011 12:46:08, Marek Polacek wrote:
> On 05/27/2011 01:20 PM, Marek Polacek wrote:
> > On 05/26/2011 06:32 PM, Pedro Alves wrote:
> >> This pattern appears in all the MI non-stop tests.  It'd be nice
> >> to move it to mi-support.exp (ideally in a preparatory patch
> >> that just does the factoring/moving, and nothing else.)
> > 
> > I'll do it in a bit.
> 
> On the other hand, what's actually the point of setting the `supported'
> variable?  The above mentioned pattern for setting the `supported'
> variable is to be found in these tests:
> 	
> 	mi-nsthrexec.exp
> 	mi-nonstop-exit.exp
> 	mi-nsintrall.exp
> 	mi-nsmoribund.exp
> 	mi-nonstop.exp
> 	mi-ns-stale-regcache.exp
> 
> But the `supported' variable is never used beyond the "-gdb-show non-stop"
> part.  What am I missing?

Eh, good question.  I don't even remember that the ,supported= bit
ever existed?  Patch to remove all of that is pre-approved.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]