This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649)
- From: Tom Tromey <tromey at redhat dot com>
- To: Marek Polacek <mpolacek at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 26 May 2011 10:23:43 -0600
- Subject: Re: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649)
- References: <4DD4F3B7.2070003@redhat.com>
>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:
Marek> 2011-05-19 Marek Polacek <mpolacek@redhat.com>
Marek> * gdb.mi/mi-nonstop.exp: Use the send_gdb+gdb_expect or mi_gdb_test
Marek> instead of the gdb_test_multiple.
Marek> set supported 0
Marek> -gdb_test_multiple "-gdb-show non-stop" "" {
Marek> - -re ".*\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
Marek> +send_gdb "-gdb-show non-stop\n"
Marek> +gdb_expect {
Marek> + -re "\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
Marek> if { $expect_out(1,string) == "1" } {
Marek> set supported 1
Marek> }
Marek> }
Marek> + -re "\\^done,value=\"off\"\r\n$mi_gdb_prompt$" {
Marek> + }
Marek> -re ".*$mi_gdb_prompt$" {
Marek> + fail "-gdb-show non-stop"
Marek> }
Marek> }
It seems wrong to me to have a 'fail' without a corresponding 'pass'.
Marek> -gdb_test_multiple "-exec-interrupt --thread 1" "interrupted" {
Marek> +send_gdb "-exec-interrupt --thread 1\n"
Marek> +gdb_expect {
Marek> -re "\\^done\r\n$mi_gdb_prompt\\*stopped\[^\r\n\]+\r\n$" {
Marek> pass "interrupted"
Marek> }
Marek> }
And likewise a pass without a fail.
Tom