This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] dwarf2read.c: handle alternate dwarf2 debug sections name.
On May 23, 2011, at 5:40 PM, Tom Tromey wrote:
> Tristan> Simply because the XCOFF maintainer was against this approach:
> Tristan> http://sourceware.org/ml/binutils/2011-04/msg00364.html
>
> I see. Onward, then.
>
> Also I see my other note was completely in error. Sigh. Sorry about
> that. I'll reply to that to eliminate confusion.
>
> I have a few nits with this patch, nothing serious.
>
>
> Tristan> + bfd_map_over_sections (objfile->obfd, dwarf2_locate_sections,
> Tristan> + (void *)names);
>
> Space after ")".
>
> Tristan> + names = (const struct dwarf2_debug_sections *)vnames;
>
> You shouldn't need the cast, but if for some reason you do, there should
> be a space after the ")".
>
> Tristan> +struct dwarf2_section_names {
> Tristan> + const char *normal;
> Tristan> + const char *compressed;
> Tristan> +};
> Tristan> +
> Tristan> +struct dwarf2_debug_sections {
>
> These should both have introductory comments explaining the purpose of
> the structs.
>
> Ok with those changes.
Thanks, committed with these changes.
Tristan.