Re: [PATCH 1/4] Really make dwarf2_get_section_info public.

[Tristan Gingold <gingold at adacore dot com>]

On May 23, 2011, at 5:15 PM, Tom Tromey wrote:

>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
> 
> Tristan> This patch is a preliminary clean-up.  Instead of using the
> Tristan> section name to get the section info, use an enum literal.
> 
> Looks reasonable, just one nit.
> 
> Tristan> It might be worth going farther and using an array of
> Tristan> dwarf2_section_info in dwarf2_per_objfile (instead of record
> Tristan> fields).  I let this decision to maintainers.
> 
> I think it is fine as is.
> 
> Tristan> +enum dwarf2_section_enum {
> Tristan> +  dwarf2_debug_frame,
> Tristan> +  dwarf2_eh_frame
> Tristan> +};
> 
> It is customary for enum constants to be upper-case.
> Ok with this change.

Thank, committed with the enum constants in upper-case.

Tristan.