This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 0/3] readline-6.2 rebase

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
Date: Wed, 11 May 2011 19:14:41 +0200
Subject: Re: [patch 0/3] readline-6.2 rebase
References: <20110501122912.GA7206@host1.jankratochvil.net> <m339knu7vm.fsf@fleche.redhat.com> <20110511060421.GA9857@host1.jankratochvil.net> <20110511163623.GB19356@adacore.com>

On Wed, 11 May 2011 18:36:23 +0200, Joel Brobecker wrote:
> I'm sensitive to the 'git bisect' argument, and I think that it's easy
> to recreate the local diff. Also, I think we've always submitted the
> vast majority of changes we make to readline, so of the changes should
> no longer be needed at the next update. So a single-commit would be
> my prefered option.

OK, I will go with this single-commit way.


> But I don't have a strong opinion. A multi-commit would be fine as well.
> Or we could cut the cake in the middle, and make 2 commits: one resetting
> readline with no change, and then one commit with all our local changes.

TBH the two-commit way seems to me to have only disadvantages of both ways.


Thanks,
Jan

References:
- [patch 0/3] readline-6.2 rebase
  - From: Jan Kratochvil
- Re: [patch 0/3] readline-6.2 rebase
  - From: Tom Tromey
- Re: [patch 0/3] readline-6.2 rebase
  - From: Jan Kratochvil
- Re: [patch 0/3] readline-6.2 rebase
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]