This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Typedef'd method parameters [1/4]
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 10 May 2011 14:39:30 -0600
- Subject: Re: [RFA] Typedef'd method parameters [1/4]
- References: <4DB09E71.305@redhat.com> <20110427184622.GA9667@host1.jankratochvil.net> <4DC975AB.3080703@redhat.com>
Keith> +static void
Keith> +do_demangled_name_parse_free_cleanup (void *data)
Keith> +{
Keith> + struct demangle_parse_info *info = (struct demangle_parse_info *) data;
Keith> + cp_demangled_name_parse_free (info);
Blank line between declarations and code.
Keith> +extern struct cleanup *
Keith> +make_cleanup_cp_demangled_name_parse_free (struct demangle_parse_info *);
I think the function name should not start in column 0 here.
Typical is column 4 or 5, I forget.
Keith> +cp_merge_demangle_parse_infos (struct demangle_parse_info *,
Keith> + struct demangle_component *,
Keith> + struct demangle_parse_info *);
Missing a `void' here. Probably also an `extern' -- I try to follow the
prevailing style in a given file.
This is ok with these nits fixed.
Tom