This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)


On Mon, 02 May 2011 19:03:38 +0200, Jan Kratochvil wrote:
> GDB complete_command also obviously leads to complete_line.

But it does not emulate _rl_find_completion_word perfectly:
  /* complete_line assumes that its first argument is somewhere
     within, and except for filenames at the beginning of, the word to
     be completed.  The following crude imitation of readline's
     word-breaking tries to accomodate this.  */


> But maybe the coverage equivalance is not so obvious as I considered it.

So OK, if you have coded it already and gdb_test "complete ..." is not
a perfect replacement I agree it should be kept just with your patch.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]