This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Eliminate user_settable_breakpoint, simplify breakpoint.c a bit (was: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs)
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at redhat dot com>, Kevin Pouget <kevin dot pouget at gmail dot com>
- Date: Wed, 27 Apr 2011 13:46:59 +0100
- Subject: Re: Eliminate user_settable_breakpoint, simplify breakpoint.c a bit (was: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs)
- References: <201104211657.05530.pedro@codesourcery.com>
On Thursday 21 April 2011 16:57:05, Pedro Alves wrote:
> I'm giving this a test run.
And retested now. No regressions. I've applied it.
Kevin, please remember to update your patch to use
user_breakpoint_p before committing. Thanks.
--
Pedro Alves
> I think the b->number >= 0 checks
> in e.g., "delete", were wrong in non-stop, as they could delete
> momentary breakpoints behind infrun's/users' backs, as not
> all momentary breakpoint types were being checked.
>
> --
> Pedro Alves
>
> 2011-04-21 Pedro Alves <pedro@codesourcery.com>
>
> gdb/
> * breakpoint.c (user_settable_breakpoint): Delete.
> (user_breakpoint_p): Remove check on user_settable_breakpoint.
> (delete_command): Check user_breakpoint_p instead of looking at
> the breakpoint's type.
> (disable_command): Ditto.
> (enable_command): Ditto.
> (delete_trace_command): Use user_breakpoint_p instead of looking
> at the breakpoint number directly. When checking if there are
> user visible tracepoints, in order to know whether to ask the user
> for confirmation, check whether the breakpoint is actually a
> tracepoint.