Re: [PATCH] Remove same-pc breakpoint notification for internal BPs

[Kevin Pouget <kevin dot pouget at gmail dot com>]

... and the missing ChangeLog:

2011-04-20  Kevin Pouget <kevin.pouget@st.com>
	* breakpoint.c (describe_other_breakpoints): Do not write 'duplicate'
	note if the breakpoint is internal.

On Wed, Apr 20, 2011 at 9:43 AM, Kevin Pouget <kevin.pouget@gmail.com> wrote:
> Hello,
>
> I'd like to suggest a patch which removes the message
>
>> (gdb) break function
>> Note: breakpoint -1 also set at pc 0x3cbd80e2a0.
>> Breakpoint 1 at 0x3cbd80e2a0
>
> when the user sets a breakpoint at the same PC as a _internal_ breakpoints.
> Internal bps are meant to be hidden from the user, so this patch goes this way
>
> (it might happen more often now that it's easy to create internal BPs
> from the Python interface, and that's what I'm doing)
>
> Cordially,
>
> Kevin
>
> (How can I run the testsuite only for gdb.base, for instance? nothing
> should fail here, because the testsuite only matches "Note: breakpoint
> \[0-9\]+ also set...", but I would have preferred actually testing
> it!)
>
> --
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 2352191..2208a80 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b,
> ? return 0;
> ?}
>
> -/* Print a message describing any breakpoints set at PC. ?This
> +/* Print a message describing any user-breakpoints set at PC. ?This
> ? ?concerns with logical breakpoints, so we match program spaces, not
> ? ?address spaces. ?*/
>
> @@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
> ? struct breakpoint *b;
>
> ? ALL_BREAKPOINTS (b)
> - ? ?others += breakpoint_has_pc (b, pspace, pc, section);
> + ? ?others += breakpoint_has_pc (b, pspace, pc, section)
> + ? ? ?&& b->number >= 0;
> ? if (others > 0)
> ? ? {
> ? ? ? if (others == 1)
> @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
> ? ? ? else /* if (others == ???) */
> ? ? ? ?printf_filtered (_("Note: breakpoints "));
> ? ? ? ALL_BREAKPOINTS (b)
> - ? ? ? if (breakpoint_has_pc (b, pspace, pc, section))
> + ? ? ? if (breakpoint_has_pc (b, pspace, pc, section) && b->number >= 0)
> ? ? ? ? ?{
> ? ? ? ? ? ?others--;
> ? ? ? ? ? ?printf_filtered ("%d", b->number);
>