This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA-v2] xtensa-tdep.c ARI fixes
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Maxim Grigoriev'" <maxim at tensilica dot com>, "'Tom Tromey'" <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Sat, 16 Apr 2011 18:07:31 +0200
- Subject: RE: [RFA-v2] xtensa-tdep.c ARI fixes
- References: <15837.6740910628$1302342165@news.gmane.org> <m34o60fuc2.fsf@fleche.redhat.com> <37948.3434990563$1302853234@news.gmane.org> <m3aafrcr4d.fsf@fleche.redhat.com> <4DA89060.9020401@tensilica.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Maxim Grigoriev
> Envoyé?: vendredi 15 avril 2011 20:37
> À?: Tom Tromey
> Cc?: Pierre Muller; gdb-patches@sourceware.org
> Objet?: Re: [RFA-v2] xtensa-tdep.c ARI fixes
>
> I tested the patch. No problems have been detected.
> Thanks much for improving Xtensa code.
May I take this as an approval?
> On 04/15/2011 11:21 AM, Tom Tromey wrote:
> >>>>>> "Pierre" == Pierre Muller<pierre.muller@ics-cnrs.unistra.fr>
writes:
> >>>>>>
> > Pierre> Here is a new version that adds this xfree call.
> > Pierre> Could someone test this patch out?
> > Pierre> Again, I have no way to trigger that code, so I can't really
test
> it.
> >
> > The patch looks good to me.
> > But I agree, testing would be nice.
> >
> > Pierre> + && (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
> >
> > Extra space after the "&&" :-)
I am lucky this is not yet tested inside ARI web page...
Otherwise my attempt of getting rid of xtensa-tdep.c source
in the ARI listing would have failed.
Thanks for noticing,
Pierre