Re: [PATCH] gdb.base/commands.exp: fix racy test (PR testsuite/12649)

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

Hi Marek,

On Wed, 13 Apr 2011 17:36:25 +0200, Marek Polacek wrote:
> 2011-04-13  Marek Polacek  <mpolacek@redhat.com>
> 
>         * gdb.base/commands.exp (redefine_backtrace_test): Fix race. 
>         New testcase `expect response to define backtrace'.  Also remove
>         redundant `default' block.

checked in for you.  If you expect more contributions you should consider
write-after-approval sourceware account:
	http://sourceware.org/cgi-bin/pdw/ps_form.cgi


> Signed-off-by: Marek Polacek <mpolacek@redhat.com>

FYI this is redundant for GNU projects, FSF copyright assignment covered by
Red Hat in your case applies instead.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-04/msg00076.html

--- src/gdb/testsuite/ChangeLog	2011/04/11 17:40:41	1.2661
+++ src/gdb/testsuite/ChangeLog	2011/04/13 15:54:04	1.2662
@@ -1,3 +1,9 @@
+2011-04-13  Marek Polacek  <mpolacek@redhat.com>
+
+	* gdb.base/commands.exp (redefine_backtrace_test): Fix race. 
+	New testcase `expect response to define backtrace'.  Also remove
+	redundant `default' block.
+
 2011-04-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* gdb.python/py-prettyprint.c (struct hint_error): New.
--- src/gdb/testsuite/gdb.base/commands.exp	2011/01/01 15:33:41	1.42
+++ src/gdb/testsuite/gdb.base/commands.exp	2011/04/13 15:54:05	1.43
@@ -704,18 +704,17 @@
     global gdb_prompt
 
     gdb_test_multiple "define backtrace" "define backtrace" {
-	-re "Really redefine built-in.*$" {
-	    send_gdb "y\n"
-	    exp_continue
+	-re "Really redefine built-in command \"backtrace\"\\? \\(y or n\\) $"  {
+	    pass "define backtrace"
 	}
+    }
 
-	-re "End with"  {
-	    pass "define backtrace in redefine_backtrace_test"
-	}
-        default {
-	    fail "(timeout or eof) define backtrace in redefine_backtrace_test"
+    gdb_test_multiple "y" "expect response to define backtrace" {
+	-re "End with a line saying just \"end\"\\.\r\n>$"  {
+	    pass "expect response to define backtrace"
 	}
     }
+
     gdb_test "echo hibob\\n\nend" \
 	    "" \
 	    "enter commands in redefine_backtrace_test"