Re: [try 2nd, patch] Move common macros to i386-dbg-reg.h

[Yao Qi <yao at codesourcery dot com>]

On 04/07/2011 11:53 PM, Mark Kettenis wrote:
>> Date: Thu, 07 Apr 2011 22:07:15 +0800
>> From: Yao Qi <yao@codesourcery.com>
>>
>> On 03/29/2011 01:02 PM, Yao Qi wrote:
>>> On 03/11/2011 01:05 PM, Yao Qi wrote:
>>>> Compared with last version, two changes are in this new patch,
>>>>  1) rename i386-common.h to i386-dbg-reg.h,
>>>>  2) add dependency tracking in gdbserver.
>>>>
>>>> OK for mainline after 7.3 branch is created?
>>>>
>>>> gdb/
>>>>
>>>> 	* i386-nat.h: Include i386-dbg-reg.h.
>>>> 	Move macros to i386-dbg-reg.h.
>>>> 	* i386-nat.c: Move macros and structs to i386-dbg-reg.h.
>>>> 	New variable struct i386_debug_reg_state state to replace
>>>> 	other variables dr_mirror, dr_ref_count, dr_control_mirror,
>>>> 	and dr_status_mirror.
>>>> 	(i386_insert_aligned_watchpoint): Add one formal parameter
>>>> 	struct i386_debug_reg_state *STATE.
>>>> 	Update code using these variables.	
>>>> 	(i386_remove_aligned_watchpoint, i386_show_dr): Likewise.
>>>> 	(i386_cleanup_dregs): Likewise.
>>>> 	(i386_handle_nonaligned_watchpoint): Likewise.
>>>> 	* common/i386-dbg-reg.h: New.  Common macros and structs.
>>>>
>>>> gdb/gdbserver/
>>>>
>>>> 	* i386-low.h: Include i386-dbg-reg.h.
>>>> 	Move macros to i386-dbg-reg.h.
>>>> 	* i386-low.c (i386_set_debug_register_length): New.
>>>> 	(i386_low_init_dregs): Call i386_set_debug_register_length.
>>>> 	* Makefile.in (i386_low_h) Depends on i386-dbg-reg.h.
>>>
>>> Ping.
>>>
>>
>> Ping?
> 
> Sorry, but as long as there is no clear vision of what gdbsever should
> be (a fully featured native GDB replacement or a lightweight remote
> protocol stub) and how to handle the configure mess, I'm hesitant to
> review diffs.

Mark,
"a fully featured native GDB replacement or a lightweight remote
protocol stub" is *not* related to this patch at all.  I am unable to do
such choice.  This patch (and other patches of mine in this area) is to
reduce source code duplication as much as possible.  No matter what
model we choose for gdbserver, this patch still makes sense, IMO.

configure problem has been fixed for some weeks by reverting my
configure/make stuff in common/ dir.

[revert patch] Remove configure/make in common/
http://sourceware.org/ml/gdb-patches/2011-03/msg00521.html

> 
> Also, posting pings without a pointer to the actual diff isn't helping
> either.

http://sourceware.org/ml/gdb-patches/2011-03/msg00648.html

-- 
Yao (éå)