This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support
- From: Yao Qi <yao at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 29 Mar 2011 19:10:57 +0800
- Subject: Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support
- References: <1255182393-15292-1-git-send-email-freephp@gmail.com> <4AD28E95.1050404@vmware.com> <7d77a27d0910111921v13a8e8acpb98c29a9aa72ed8@mail.gmail.com> <AANLkTimZi1dV7ao-0kpAfhDogtXnDwcuJPDwEr5hEGVq@mail.gmail.com> <4C929A9C.1050601@vmware.com> <AANLkTinrdVcu-5YpHZ+By99OcowB5fU1W7rs524PohoJ@mail.gmail.com>
On 03/29/2011 06:11 PM, Jiang Jilin wrote:
I am not the people to approve this patch. Some comments on code format
and indent.
> 2011-03-29 Jiang Jilin <freephp@gmail.com>
There should be a newline here. Please reference other changelog entries.
> * i386-tdep.c (i386_process_record): Rewrite the codes for
> opcode 0x0f01 and add more instructions support
> + switch (reg_rm)
> + {
> + /* vmcall */
> + case 0x01:
> + /* vmlaunch */
Looks like there are two extra spaces in front of your comment. Please
remove them. There are several instances of this problem in your patch.
> +
> + /* We have to store at least (4 + 2 = 6) bytes,
> + or (8 + 2 = 10) bytes at most. */
According to my limited English knowledge, it should be "6 bytes at
least *and* 10 bytes at most".
> + if (i386_record_lea_modrm_addr (&ir, &tmpu64))
> + return -1;
--
Yao (éå)