This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa] Use get_number_or_range for kill inferior etc.
- From: Pedro Alves <pedro at codesourcery dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 25 Feb 2011 20:51:36 +0000
- Subject: Re: [rfa] Use get_number_or_range for kill inferior etc.
- References: <4D680E45.50607@vmware.com>
On Friday 25 February 2011 20:17:09, Michael Snyder wrote:
> - tp = any_thread_of_process (pid);
> - if (!tp)
> - error (_("Inferior has no threads."));
> + tp = any_thread_of_process (pid);
> + if (!tp)
> + error (_("Inferior has no threads."));
This is fine with me, but I think all the errors should
be updated to include the inferior ID that caused the
trouble.
> error (_("Requires argument (inferior id to detach)"));
Probably want to make these plural as well.
On Friday 25 February 2011 20:17:09, Michael Snyder wrote:
> +gdb_test_no_output "remove-inferior 2-3" "remove-inferior 2-3"
Plural?
If you only have say inferiors 1, 3 and 5, these commands will
error out if you do 'CMD 1-5', claiming 2 or 4 are invalid.
Not sure that's user friendly.
And you'll need to update the docs as well, at least
because you renamed some commands.
--
Pedro Alves