This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Ping: [Patch v2] Add mips*-linux* catch syscall support.
- From: Michael Snyder <msnyder at vmware dot com>
- To: David Daney <ddaney at caviumnetworks dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 31 Jan 2011 11:45:46 -0800
- Subject: Re: Ping: [Patch v2] Add mips*-linux* catch syscall support.
- References: <4D3DD73C.9060201@caviumnetworks.com> <4D46F658.3020302@caviumnetworks.com>
David Daney wrote:
If it is not too much trouble, could a Maintainer review this patch?
Thanks in advance,
David Daney
There's an off-by-one indentation here:
+static LONGEST
+mips_linux_get_syscall_number (struct gdbarch *gdbarch,
+ ptid_t ptid)
Other than that, the part in mips-linux-tdep.c looks reasonable.
I don't understand the xml parts well enough to comment.