This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: FYI: add user_breakpoint_p
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 31 Jan 2011 06:05:43 +0400
- Subject: Re: FYI: add user_breakpoint_p
- References: <m362t9lpix.fsf@fleche.redhat.com>
> 2011-01-27 Tom Tromey <tromey@redhat.com>
>
> * breakpoint.h (user_breakpoint_p): Declare.
> * breakpoint.c (user_breakpoint_p): New function.
> (breakpoint_1): Use it.
> (save_breakpoints): Likewise.
I love these little cleanups :-).
Just one question about style:
> - if (!user_settable_breakpoint (tp) || tp->number < 0)
> + if (! user_breakpoint_p (tp))
Do we agree on whether to write this as the above, or whether we should
not have a space between the '!' and the expression being negated:
if (! user_breakpoint_p (tp))
?
I did a rough count, and currently we have a bout 500 instance with the
space, and 2800 without...
--
Joel