This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Changes to the OpenCL testsuite
- From: Yao Qi <yao at codesourcery dot com>
- To: Ken Werner <ken at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 25 Jan 2011 05:58:40 +0800
- Subject: Re: [patch] Changes to the OpenCL testsuite
- References: <201101242136.29609.ken@linux.vnet.ibm.com>
On 01/25/2011 04:36 AM, Ken Werner wrote:
> 2011-01-24 Ken Werner <ken.werner@de.ibm.com>
>
> * gdb.opencl/convs_casts.cl: Move program scope variables into the
> OpenCL kernel function. Add a comment as marker.
> * gdb.opencl/datatypes.cl: Likewise.
> * gdb.opencl/operators.cl: Likewise.
> * gdb.opencl/vec_comps.cl: Likewise.
> * gdb.opencl/convs_casts.exp: Replace gdb_test_multiple by gdb_test.
> Add breakpoint at the marker comment.
> * gdb.opencl/datatypes.exp: Likewise.
> * gdb.opencl/operators.exp: Likewise.
> * gdb.opencl/vec_comps.exp: Likewise.
>
I am not the people to approve this patch. Some of my cents below,
> Index: gdb/testsuite/gdb.opencl/convs_casts.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.opencl/convs_casts.exp,v
> retrieving revision 1.2
> diff -p -u -r1.2 convs_casts.exp
> --- gdb/testsuite/gdb.opencl/convs_casts.exp 1 Jan 2011 15:33:48 -0000 1.2
> +++ gdb/testsuite/gdb.opencl/convs_casts.exp 24 Jan 2011 19:55:01 -0000
> @@ -1,4 +1,4 @@
> -# Copyright 2010, 2011 Free Software Foundation, Inc.
> +# Copyright 2010 Free Software Foundation, Inc.
Any reason to remove "2011" here? At least, this change is not
reflected in ChangeLog entry. Presumably, it is changed by mistake, if
so, we should remove this chunk from patch.
> -__kernel void testkernel (__global int *data)
> -{
> + /* marker! */
Generally, we leave either period/two-spaces or single space at the end
of comment. In your case, we can use single space since your comment is
short.
--
Yao (éå)