This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PING: [patch, testsuite] General ARM target triplet
- From: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org, Andreas Schwab <schwab at linux-m68k dot org>, Richard Earnshaw <rearnsha at arm dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Thu, 13 Jan 2011 13:44:51 +0000
- Subject: Re: PING: [patch, testsuite] General ARM target triplet
- References: <4CF91BD4.7090708@codesourcery.com> <201012131407.08185.pedro@codesourcery.com> <4D063BA8.4000404@codesourcery.com> <201012131539.22392.pedro@codesourcery.com> <4D25CD5E.4030204@codesourcery.com>
On Thu, 2011-01-06 at 22:10 +0800, Yao Qi wrote:
> On 12/13/2010 11:39 PM, Pedro Alves wrote:
> >> > OK, I combine them together in one single patch this time.
> > Thanks. If/when everyone's happy with the triplet bits
> > proper, this is okay.
>
> Ping. Are you happy with this triplet? :-)
>
> http://sourceware.org/ml/gdb-patches/2010-12/msg00187.html
>
Looks okay to me apart from the following:
> --- a/gdb/testsuite/gdb.asm/asm-source.exp
> +++ b/gdb/testsuite/gdb.asm/asm-source.exp
> @@ -40,10 +40,7 @@ switch -glob -- [istarget] {
> set asm-flags "-no-mdebug -I${srcdir}/${subdir} -I${objdir}/${subdir}"
> set debug-flags "-gdwarf-2"
> }
> - "*arm-*-*" {
> - set asm-arch arm
> - }
> - "xscale-*-*" {
> + "*arm*-*-*" {
Shouldn't the test read "arm*-*-*" (following on from Richard's and Joseph's comments?
Note that I am not a maintainer and so this is not an approval.
Thanks,
Matt
--
Matthew Gretton-Dann
Principal Engineer - PDSW Tools
ARM Ltd