This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ping] Re: [rfa v2] Detect __aeabi_read_tp even without symbols
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: dan at codesourcery dot com (Daniel Jacobowitz), rearnsha at arm dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 11 Jan 2011 18:27:35 +0100 (CET)
- Subject: [ping] Re: [rfa v2] Detect __aeabi_read_tp even without symbols
Dan Jacobowitz wrote:
> On Wed, Dec 01, 2010 at 05:05:17PM +0100, Ulrich Weigand wrote:
> > Dan Jacobowitz wrote:
> > > The approach looks good to me. Two comments on the implementation:
> > > the explanation is just as valid in the ARM case as the Thumb case,
> > > and we should not do this read if we know the name of the target
> > > function and it is different from __aeabi_read_tp. Both of these can
> > > be accomplished by putting the check in skip_prologue_function
> > > instead.
> >
> > This version implements the suggestion to move the check into
> > skip_prologue_function itself (which requires passing some
> > additional data into that function).
> >
> > [ As an aside, the new implementation also avoids the empty-
> > statement construct that Mark disliked ... ]
> >
> > Re-tested with same results on armv7l-linux-gnueabi.
> >
> > OK for mainline?
>
> Looks good to me.
Thanks, Dan!
Richard, is the patch OK for mainline now?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com