This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Implement support for PowerPC BookE ranged watchpoints
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Date: Mon, 10 Jan 2011 23:36:24 +0000
- Subject: Re: [RFA] Implement support for PowerPC BookE ranged watchpoints
- References: <1294687058.3162.44.camel@hactar>
On Monday 10 January 2011 19:17:38, Thiago Jung Bauermann wrote:
> + the memory layout of a scalar type. E.g., an array or struct with only one
Double space.
> +static int
> +resources_needed_watchpoint (const struct bp_location *bl)
> +{
> + int length = bl->owner->exact? 1 : bl->length;
> +
> + return target_region_ok_for_hw_watchpoint (bl->address, length);
> }
Indenting looks wrong. Otherwise okay to commit. Thanks for persevering!
I don't _think_ the target_region_ok_for_hw_watchpoint semantics
change breaks any target.
I dare you to implement or think about how you'd implement step 2.5
of my list with this interface. :-) You don't seem to have a way
for the target to return "I can hardware assist watching this memory
region, and I need exactly zero debug registers to do it." ?
--
Pedro Alves