This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE
- From: Doug Evans <dje at google dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Mon, 10 Jan 2011 10:07:45 -0800
- Subject: Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE
- References: <1293668913-9172-1-git-send-email-vapier@gentoo.org> <201101082251.41469.vapier@gentoo.org>
On Sat, Jan 8, 2011 at 7:51 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote:
>> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated
>> list of devices that override the defaults" while the 3rd arg is "a space
>> separated list of extra target specific devices". ?But the macro doesn't
>> seem to treat the 2nd arg this way.
>>
>> Instead, it will always add the default list of devices, and only add the
>> extra target specific devices if the 2nd arg is not specified. ?So rework
>> the logic slightly to handle the 2nd arg as documented.
>>
>> This shouldn't affect any targets in the tree as no one passes in a non-
>> empty value as the 2nd arg.
>
> ping ...
> -mike
>
Hi. This is ok.