This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: add noreturn markings to more hw abort/halt funcs
- From: Doug Evans <dje at google dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Mon, 10 Jan 2011 10:00:34 -0800
- Subject: Re: [PATCH] sim: add noreturn markings to more hw abort/halt funcs
- References: <1294539266-12692-1-git-send-email-vapier@gentoo.org>
On Sat, Jan 8, 2011 at 6:14 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> These functions either call abort() themselves, or call functions which
> are already marked noreturn. ?Either way, they don't return, so mark them
> as such so calling code can assume this. ?This fixes some uninitialized
> warnings due to code paths that end in an abort function.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> 2010-01-08 ?Mike Frysinger ?<vapier@gentoo.org>
>
> ? ? ? ?* hw-device.h (hw_abort, hw_vabort, hw_halt): Add noreturn attribute.
> ? ? ? ?* sim-hw.h (sim_hw_abort): Likewise.
This is ok.