This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: New ARI warning Thu Jan 6 01:53:36 UTC 2011
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 6 Jan 2011 13:32:42 +0400
- Subject: Re: New ARI warning Thu Jan 6 01:53:36 UTC 2011
- References: <20110106015336.GA32352@sourceware.org>
> 521,522d520
> < gdb/linespec.c:1456: gettext: trailing new line: A message should not have a trailing new line
[...]
All ARI violations reported in this email should be taken care of
with the attached patch.
Tested on x86_64-linux (rebuilding solib-irix.c only). Checked in.
--
Joel
commit fd2e675aedc299242ad4d2a454e4cb60ee9ecf3c
Author: Joel Brobecker <brobecker@adacore.com>
Date: Thu Jan 6 13:28:41 2011 +0400
Remove trailing new-line at end of error string
gdb/ChangeLog:
* linespec.c (decode_compound, find_method): Remove trailing \n
at end of error string.
* solib-irix.c (irix_current_sos): Likewise.
* varobj.c (uninstall_variable): Likewise.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 60676a3..42e77dc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2011-01-06 Joel Brobecker <brobecker@adacore.com>
+ * linespec.c (decode_compound, find_method): Remove trailing \n
+ at end of error string.
+ * solib-irix.c (irix_current_sos): Likewise.
+ * varobj.c (uninstall_variable): Likewise.
+
+2011-01-06 Joel Brobecker <brobecker@adacore.com>
+
* copyright.py: New script.
* copyright.sh (byhand): Add *.ads, *.adb, *.gpr and *.inc.
Launch emacs without exec'ing. Call copyright.py afterwards.
diff --git a/gdb/linespec.c b/gdb/linespec.c
index dffbb36..ae48de7 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -1460,7 +1460,7 @@ decode_compound (char **argptr, int funfirstline, char ***canonical,
{
xfree (values.sals);
error (_("the class `%s' does not have "
- "any method instance named %s\n"),
+ "any method instance named %s"),
SYMBOL_PRINT_NAME (sym_class), copy);
}
}
@@ -1625,7 +1625,7 @@ find_method (int funfirstline, char ***canonical, char *saved_arg,
}
error (_("the class `%s' does not have "
- "any method instance named %s\n"),
+ "any method instance named %s"),
SYMBOL_PRINT_NAME (sym_class), copy);
}
diff --git a/gdb/solib-irix.c b/gdb/solib-irix.c
index f233d4a..bd577a0 100644
--- a/gdb/solib-irix.c
+++ b/gdb/solib-irix.c
@@ -572,8 +572,8 @@ irix_current_sos (void)
if (name_size >= SO_NAME_MAX_PATH_SIZE)
{
name_size = SO_NAME_MAX_PATH_SIZE - 1;
- warning ("current_sos: truncating name of "
- "%d characters to only %d characters",
+ warning (_("current_sos: truncating name of "
+ "%d characters to only %d characters"),
lm.pathname_len, name_size);
}
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 8cfcccf..1792c2e 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -2060,8 +2060,8 @@ uninstall_variable (struct varobj *var)
}
if (cr == NULL)
{
- warning ("Assertion failed: Could not find "
- "varobj \"%s\" in root list",
+ warning (_("Assertion failed: Could not find "
+ "varobj \"%s\" in root list"),
var->obj_name);
return;
}