This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] make info regression on --with-system-readline


> Date: Sat, 1 Jan 2011 02:13:24 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Tom Tromey <tromey@redhat.com>
> 
> since:
> 	[2/2] RFA: --with-system-readline -vs- gdb.texinfo
> 	http://sourceware.org/ml/gdb-patches/2010-11/msg00270.html
> 
> $ rm -rf gdb-7.2.50.20101231; tar xjf gdb-7.2.50.20101231.tar.bz2; cd gdb-7.2.50.20101231; CFLAGS= ./configure --with-system-readline; make; rm gdb/doc/gdb.info; make -C gdb/doc gdb.info
> ->
> [...]
> makeinfo  -I ./../mi -I . \
> 	-o gdb.info ./gdb.texinfo
> ./gdb.texinfo:30521: @include `rluser.texi': No such file or directory.
> ./gdb.texinfo:30521: @include `inc-hist.texinfo': No such file or directory.
> [...]
> Fedora 14 x86_64
> 
> It is because GDBvn.texi has started to depend on the configure options.

Aren't you supposed to "make distclean" whenever you reconfigure?
That's what I do in every project, because I don't trust the Makefiles
to DTRT in such case.  E.g., what about all the *.o files you didn't
remove?

> -GDBvn.texi : ${gdbdir}/version.in
> +GDBvn.texi : ${gdbdir}/version.in Makefile

Thanks.

However, I don't like rules that depend of Makefiles, because they
tend to be re-run too much for no good reason.  Note that this will
re-make the docs each time you reconfigure, even if you didn't change
the configuration.

But if I'm the only one who dislikes this, I won't object to the
change.

> Another issue is that GDBvn.texi and gdb-cfg.texi should not be distributed.

How can we not distribute them when gdb.texinfo @include's them, and
needs that for setting some of the variables the manual uses?  If we
don't distribute them, end users will be unable to rebuild the manual.
What am I missing here?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]