This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/2] build id


> Date: Mon, 29 Nov 2010 16:48:59 -0500
> From: sami wagiaalla <swagiaal@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> Thanks for the review :) The attached patch combines the two patches as 
> Joel preferred and address the issues Eli brought up. Except for the 
> FIXME's. I could not figure out what was meant by the FIXME's so I have 
> asked Tromey and Jan for help. Or if anyone else is interested.
> 
> Patch Attached.

Thanks.

> +You can also adjust the current verbosity of the @dfn{build id} locating.

You are still using @dfn when you need to reference "build id".  I
thought I explained that this wasn't needed.

> +executable. This feature can be turned on or off through the following
             ^^
Two spaces, please.

The patch for the manual is okay with these changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]