This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] iFort compat.: case insensitive symbols (PR 11313)
> If there are any concerns about it (I do not think there should be any while
> looking and the disassembly plus glibc's __ctype_tolower_loc) we should also
> ask why GDB already uses locale-conforming tolower while gcc uses TOLOWER.
>
> GDB could also use it, it is in libiberty. That one has "zero" cost.
I was actually wondering about the change in the hash algorithm more
than the cost of calling tolower. For instance, "tmp" and "Tmp" would
have had different hash values, but not anymore. So, presumably, when
you start looking up for "tmp", the associated hash bucket will also
contain "Tmp" whereas it wouldn't before. I need to look at the actual
hashing parameters to see if we can figure out whether this should have
any real effect in practice... If the number of elements in each bucket
is reasonable, a few more iterations shouldn't be an issue.
--
Joel