This is the mail archive of the
mailing list for the GDB project.
Re: [patch] Fix --enable-plugins --without-python
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 2 Nov 2010 11:43:41 -0700
- Subject: Re: [patch] Fix --enable-plugins --without-python
- References: <20101017104101.GA9276@host1.dyn.jankratochvil.net>
> 2010-10-17 Jan Kratochvil <email@example.com>
> Fix configure --enable-plugins --without-python.
> * configure.ac (for ELF support in BFD) <"$plugins" = "yes">: New.
> * configure: Regenerate.
Grumpf! It would be nice if BFD was telling us which libraries we need
to link against bfd, just as Gtk+, Python, etc, do.
I'm a little concern that this is a bit primitive, and good enough only
on GNU/Linux or maybe Unix. Or rather, that this might break the build
on some platforms such as Windows. But that's not the case, since
the user would need to use --enable-plugins to enable plugins (it's
not automatic), so I don't see a better solution that's actually
worth the effort.
> +if test "$plugins" = "yes"; then
> + LIBS="-ldl $LIBS"
A comment explaining the dependency would be nice (likewise below).
> + if test "$plugins" = "yes"; then
> + OLD_LIBS="-ldl $OLD_LIBS"
> + fi