This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: Your INTERMEDIATE_ENCODING patch for Solaris
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Tom Tromey'" <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 23 Sep 2010 09:19:39 +0200
- Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris
- References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <m3aaolgj0g.fsf@fleche.redhat.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <m38w43dho9.fsf@fleche.redhat.com> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <m34oeq8u1g.fsf@fleche.redhat.com> <m339twkmj5.fsf@fleche.redhat.com> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <m3k4n6hgqe.fsf@fleche.redhat.com> <44796.6229789474$1283326243@news.gmane.org> <m362yp9kaj.fsf@fleche.redhat.com> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> <m362yo88fj.fsf@fleche.redhat.com> <m3hbhs59iu.fsf@fleche.redhat.com> <m3aaniwykg.fsf@fleche.redhat.com> <001f01cb5574$78252a60$686f7f20$@muller@ics-cnrs.unistra.fr> <m3d3sdr16g.fsf@fleche.redhat.com> <20078.2261243605$1284672670@news.gmane.org> <m3y6b1nmn2.fsf@fleche.redhat.com> <001101cb5663$f6011c10$e2035430$@muller@ics-cnrs.unistra.fr> <m37hid5wep.fsf@fleche.redhat.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: Wednesday, September 22, 2010 10:57 PM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: Your INTERMEDIATE_ENCODING patch for Solaris
>
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
> writes:
>
> Pierre> I found the libiconv version 1.5
> Pierre> installed it on a x86 Open Solaris machine,
> Pierre> modified gdb_wchar.h to use _LIBICONV_VERSION >= 0x105
> Pierre> and got an gdb executable linked to libiconv version 1.5,
> Pierre> using --with-libiconv-prefix=/usr/local/src/test32
> Pierre> (the installation prefix I used for 1.5 libiconv).
> Pierre> I tested charset.exp result on that executable,
> Pierre> and got a lot of failures:
> [...]
>
> Pierre> But I was wondering if the problem is not coming from the
> Pierre> fact that for 1.5 libiconv find_charset_names function
> Pierre> directly calls 'iconv -l' (because iconvlist is not present
> Pierre> in this version of the library).
>
> Ouch.
>
> Pierre> I also downloaded version 1.8 of libiconv,
> Pierre> and checked GDB linked to that version:
> Pierre> the results of charset.exp are the same as 1.13.1 (2 FAILs)
>
> Yeah, how about we make x0108 the minimal acceptable version?
> It was released in 2002, that seems plenty old to me.
>
> If you agree, I will make the change.
I agree, furthermore HAVE_LIBICONVLIST
should always be set in config.h in that case,
which avoids the direct call to 'iconv -l'.
> Pierre> PS: Support of libc iconv for Solaris could probably be
> Pierre> enhanced by a better parsing of 'iconv -l' output...
>
> I think there isn't much reason to do it, since we're planning to avoid
> Solaris iconv completely. If somebody wants to make the effort,
> though,
> it is fine by me.
Not sure I will have time for that...
Pierre