This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA 1/5] New patches to support --enable-targets=all for mingw64
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 14 Sep 2010 10:01:59 +0200
- Subject: RE: [RFA 1/5] New patches to support --enable-targets=all for mingw64
- References: <003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr> <20100913175106.GA3845@adacore.com>
> Objet?: Re: [RFA 1/5] New patches to support --enable-targets=all for
> mingw64
>
> (the issues you have encountered are very familiar to me, since I had
> the same problem when I ported the native debugger to 64bit windows).
>
> > 1) Replace remaining #include <winsock.h> by #inlcude <winsock2.h>
> > in remote-m32r-sdi.c and m32r-rom.c
> >
> > I apologize to the person that already submitted a similar
> > change, but I was unable to find it again.
> > I vaguely remember that we already discussed this once, but there
> > are still two <winsock.h> inlcudes in gdb HEAD.
> [...]
> > 2010-09-10 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > * m32r-rom.c: Replace winsock.h with winsock2.h header.
> > * remote-m32r-sdi.c: Replace winsock.h by winsock2.h.
>
> I don't know much about Windows systems, but since no one reviewed
> the patch, I did some research. I believe the patch is correct, since
> we are linking gdb and gdbserver against ws2_32.lib, so the correct
> include is winsock2.h (winsock.h is for wsock32.lib).
>
> http://cboard.cprogramming.com/networking-device-communication/71596-
> winsock-vs-winsock2.html
>
> So this is OK.
Thanks for the approval,
patch committed.
Pierre Muller
Pascal language support maintainer for GDB