This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: Remove amd64_register_name
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: hjl dot tools at gmail dot com
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 11 Sep 2010 20:34:03 +0200 (CEST)
- Subject: Re: PATCH: Remove amd64_register_name
- References: <20100911163414.GA7422@intel.com>
> Date: Sat, 11 Sep 2010 09:34:14 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
>
> Hi,
>
> amd64_register_name is the same as i386_register_name. There is no
> need for it. This patch removes it. Tested on Linux/x86-64 and
> Linux/x86-64 with AVX. OK to install?
Yes
> ---
> 2010-09-11 H.J. Lu <hongjiu.lu@intel.com>
>
> * amd64-tdep.c (amd64_register_name): Removed.
> (amd64_init_abi): Don't call set_gdbarch_register_name.
>
> * i386-tdep.c (i386_ymmh_regnum_p): Make it static.
>
> * i386-tdep.h (i386_ymmh_regnum_p): Removed.
>
> diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
> index 9feed90..5472db1 100644
> --- a/gdb/amd64-tdep.c
> +++ b/gdb/amd64-tdep.c
> @@ -257,19 +257,6 @@ static const char *amd64_dword_names[] =
> "r8d", "r9d", "r10d", "r11d", "r12d", "r13d", "r14d", "r15d"
> };
>
> -/* Return the name of register REGNUM, or the empty string if it is
> - an anonymous register. */
> -
> -static const char *
> -amd64_register_name (struct gdbarch *gdbarch, int regnum)
> -{
> - /* Hide the upper YMM registers. */
> - if (i386_ymmh_regnum_p (gdbarch, regnum))
> - return "";
> -
> - return tdesc_register_name (gdbarch, regnum);
> -}
> -
> /* Return the name of register REGNUM. */
>
> static const char *
> @@ -2407,8 +2394,6 @@ amd64_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>
> set_tdesc_pseudo_register_name (gdbarch, amd64_pseudo_register_name);
>
> - set_gdbarch_register_name (gdbarch, amd64_register_name);
> -
> /* AMD64 has an FPU and 16 SSE registers. */
> tdep->st0_regnum = AMD64_ST0_REGNUM;
> tdep->num_xmm_regs = 16;
> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
> index 435b623..ea282a7 100644
> --- a/gdb/i386-tdep.c
> +++ b/gdb/i386-tdep.c
> @@ -165,7 +165,7 @@ i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum)
> return regnum >= 0 && regnum < tdep->num_dword_regs;
> }
>
> -int
> +static int
> i386_ymmh_regnum_p (struct gdbarch *gdbarch, int regnum)
> {
> struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
> diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h
> index 49e0727..4d0bae7 100644
> --- a/gdb/i386-tdep.h
> +++ b/gdb/i386-tdep.h
> @@ -307,7 +307,6 @@ extern int i386_word_regnum_p (struct gdbarch *gdbarch, int regnum);
> extern int i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum);
> extern int i386_xmm_regnum_p (struct gdbarch *gdbarch, int regnum);
> extern int i386_ymm_regnum_p (struct gdbarch *gdbarch, int regnum);
> -extern int i386_ymmh_regnum_p (struct gdbarch *gdbarch, int regnum);
>
> extern const char *i386_pseudo_register_name (struct gdbarch *gdbarch,
> int regnum);
>