This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t

From: Michael Snyder <msnyder at vmware dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Mon, 30 Aug 2010 10:33:52 -0700
Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
References: <20100830071040.GB6831@host1.dyn.jankratochvil.net> <201008300814.o7U8ECNZ009010@glazunov.sibelius.xs4all.nl> <20100830082407.GA6881@host1.dyn.jankratochvil.net>

Jan Kratochvil wrote:

On Mon, 30 Aug 2010 10:14:12 +0200, Mark Kettenis wrote:

The _t suffix is actually reserved by POSIX, so using it is actually a
bad idea.  Perhaps change it to gdb_target_signal, or just
target_signal (making it a typedef for an anonymous enum)?

I see too many types in GDB and everywhere ending with _t (ptid_t for all).

I do not mind at all about the type name but before reposting the patchset
I would like agreement from one more global maintainer.

ptid_t was an extension from pid_t, which is a posix typedef I think.

References:
- [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Jan Kratochvil
- Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Mark Kettenis
- Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]