This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Delayed physnames, revisited
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 19 Aug 2010 16:25:52 -0700
- Subject: Re: [RFA] Delayed physnames, revisited
- References: <4C460EAC.3040600@redhat.com> <m3iq362y55.fsf@fleche.redhat.com>
On Thu, Aug 19, 2010 at 12:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Sorry about the long delay on this.
> Please ping patches regularly, it helps embarrass us into responding ;-)
>
> Keith> I have finally gotten around to revisiting this patch and rebasing it
> Keith> on top of all the recent churn in dwarf2read.c. I have also (finally)
> Keith> developed a test case for the "trivial" obstack leak that I previously
> Keith> reported. [It was trivial, but also very dependent on compiler and STL
> Keith> implementation. That made it very non-trivial. :-)]
>
> This patch is ok. ?Thanks.
Not to nitpick or anything,
Well, yes to nitpick ... :-)
Folks are great at enforcing things like putting a space after the
function name in a function call, but not so good at enforcing having
a blank line between a function's comment and definition.
Keith, can you fix that?