RE: [patch] create and use symbol_set_language

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

Hi Sami,

  I just looked at your patch, which seems
quite straightforward.

  Nevertheless, it seems that 
it contains a change that is not commented:

@@ -393,13 +393,11 @@ symbol_get_demangled_name (const struct
general_symbol_info *gsymbol)
 /* Initialize the language dependent portion of a symbol
    depending upon the language for the symbol. */
 void
-symbol_init_language_specific (struct general_symbol_info *gsymbol,
-			       enum language language)
+symbol_set_language (struct general_symbol_info *gsymbol,
+                     enum language language)
 {
-
   gsymbol->language = language;
-  if (gsymbol->language == language_cplus
-      || gsymbol->language == language_d
+  if (gsymbol->language == language_d
       || gsymbol->language == language_java
       || gsymbol->language == language_objc
       || gsymbol->language == language_fortran)

  The removal of the 'gsymbol->language == language_cplus'
condition seems to be outside of the scope of the patch you
describe, which seems otherwise quite straightforward. 

  Could you please comment on the reason of that specific change?
Is it really part of that patch or shouldn't it be submitted
separately? I must confess that I didn't even try to
look at the source code after the 'if', but just reacted quickly
on something that seem 'off topic' as compared to
your patch description.

Pierre


> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de sami wagiaalla
> Envoyé?: Tuesday, August 03, 2010 4:57 PM
> À?: gdb-patches@sourceware.org
> Objet?: [patch] create and use symbol_set_language
> 
> This patch renames SYMBOL_INIT_LANGUAGE_SPECIFIC to SYMBOL_SET_LANGUAGE
> and symbol_init_language_specific to symbol_set_language, and uses them
> everywhere the language of a symbol is set. Usually through
> SYMBOL_LANGUAGE (sym) = language
> 
> This was tested by running the test suit on F13 with gcc 4.4.4 on x8664
> no regressions.
> 
> Let me know what you think.
> 
> 
> Sami