This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
gdb-rx-tdep: make RXO_branch more robust
- From: DJ Delorie <dj at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: kevinb at redhat dot com
- Date: Wed, 28 Jul 2010 22:29:09 -0400
- Subject: gdb-rx-tdep: make RXO_branch more robust
My next sim patch changes RXO_branch to not have a condition for
unconditional branches (as opposed to the "always true" condition).
Regardless, I think there's no need to check for RX_Operand_Condition
anyway - previously, it was the *only* value that type could be, for
RXO_branch. I'd change it to check for unconditional, but I don't
want to break things between this patch and the next. Ok?
* rx-tdep.c (rx_analyze_prologue): Don't require branches to have
conditions.
Index: gdb/rx-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rx-tdep.c,v
retrieving revision 1.3
diff -p -U3 -r1.3 rx-tdep.c
--- gdb/rx-tdep.c 24 Jun 2010 20:38:04 -0000 1.3
+++ gdb/rx-tdep.c 29 Jul 2010 02:25:34 -0000
@@ -296,7 +296,6 @@ rx_analyze_prologue (CORE_ADDR start_pc,
}
else if (opc.id == RXO_branch
&& opc.op[0].type == RX_Operand_Immediate
- && opc.op[1].type == RX_Operand_Condition
&& next_pc < opc.op[0].addend)
{
/* When a loop appears as the first statement of a function