This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: fix another regression w/ gcc svn trunk
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 28 Jul 2010 10:44:56 -0700
- Subject: Re: RFC: fix another regression w/ gcc svn trunk
- References: <m34ofkrg96.fsf@fleche.redhat.com>
> In the absence of comments I am going to check this in.
> I am undecided as to whether this belongs in 7.2.
>
> Tom
>
> 2010-07-27 Tom Tromey <tromey@redhat.com>
>
> * dwarf2read.c (dwarf2_const_value_data): Never sign extend.
This looks reasonable to me. For 7.2, I'm also 50/50, so I propose
the following compromise: Since it is mostly affecting an unreleased
version of GCC, we can leave this out of 7.2, and reconsider for 7.2.1
after an observation period on the head?
> +/* Given an attr with a DW_FORM_dataN value in host byte order,
> + zero-extend it as appropriate for the symbol's type. */
I think it would be nice to explain in the comment the reason for
zero-extending as opposed to sign-extending? In particular, mention
the fact the expected behavior, according to the DWARF committee is
not precisely defined, and the reason for choosing zero-extension
is because GCC has been following that convention for a while.
--
Joel