This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix build failure for win64, revise some format strings
>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:
Ozkan> gdb/gdbserver/
Ozkan> * server.c (handle_query): For windows, Use %I64d instead of
Ozkan> %lld in the sprintf format string.
I don't know much about gdbserver. So I am going to ask that someone
else look at this part.
Ozkan> (Note: debug_to_region_ok_for_hw_watchpoint() specifically
Ozkan> did not use 0x%lx but only %ld for the addr value. Should I
Ozkan> not care, or should I change my patch to use
Ozkan> host_address_to_string ((void *) addr) + 2
Ozkan> ... to skip the "0x" instead?
Don't worry about it, using host_address_to_string is fine.
Ozkan> + host_address_to_string ((void *) bp_tgt->placed_address),
I think you should not need these casts to void*.
The gdb parts of this patch are ok with that change. Thanks.
Tom