This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[rfa] Fix comment in can_use_hardware_watchpoint
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Thu, 01 Jul 2010 16:53:59 -0300
- Subject: [rfa] Fix comment in can_use_hardware_watchpoint
Hi,
Ulrich Weigand elucidated a question asked in a comment in
can_use_hardware_watchpoint. This patch fixes it.
Thanks and regards,
Thiago Jung Bauermann
IBM Linux Technology Center
2010-07-01 Ulrich Weigand <uweigand@de.ibm.com>
Thiago Jung Bauermann <bauerman@br.ibm.com>
* breakpoint.c (can_use_hardware_watchpoint): Answer "what does this
represent?" question in comment. Change comment to a proper sentence.
Index: gdb/breakpoint.c
===================================================================
--- gdb.orig/breakpoint.c 2010-06-30 23:24:53.000000000 -0300
+++ gdb/breakpoint.c 2010-06-30 23:25:02.000000000 -0300
@@ -8147,9 +8147,9 @@ can_use_hardware_watchpoint (struct valu
}
else if (VALUE_LVAL (v) != not_lval
&& deprecated_value_modifiable (v) == 0)
- return 0; /* ??? What does this represent? */
+ return 0; /* These are values from the history (e.g., $1). */
else if (VALUE_LVAL (v) == lval_register)
- return 0; /* cannot watch a register with a HW watchpoint */
+ return 0; /* Cannot watch a register with a HW watchpoint. */
}
/* The expression itself looks suitable for using a hardware