This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix C++ leading :: (PR c++/11703 and PR gdb/1448)
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Sami Wagiaalla <swagiaal at redhat dot com>
- Date: Mon, 28 Jun 2010 12:28:27 -0600
- Subject: Re: [patch] Fix C++ leading :: (PR c++/11703 and PR gdb/1448)
- References: <20100626082205.GA30439@host0.dyn.jankratochvil.net>
- Reply-to: tromey at redhat dot com
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Maybe a more clear/straightforward conditional could be chosen than
Jan> `first_was_coloncolon && first_iter' to just really check
Jan> yylval.sval.ptr has been initialized. But from some higher level
Jan> point of view the equivalent conditional `first_was_coloncolon &&
Jan> first_iter' makes sense there.
I agree.
Jan> 2010-06-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix PR c++/11703 and PR gdb/1448.
Jan> * c-exp.y (yylex) <last_was_coloncolon && first_was_coloncolon>: Add
Jan> FIRST_ITER check.
Jan> 2010-06-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Test PR c++/11703 and PR gdb/1448.
Jan> * gdb.cp/namespace.exp (whatis ::C::cOtherFileVar)
Jan> (print ::C::cOtherFileVar)
Jan> (print ::C::OtherFileClass::cOtherFileClassVar): Remove KFAIL for
Jan> c++/11703.
Jan> (ptype ::C::NestedClass): Remove KFAIL for gdb/1448.
This is ok. Thanks for fixing this.
Tom