This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] PR python/11407
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 24 Jun 2010 17:09:54 +0200
- Subject: Re: [patch] PR python/11407
- References: <4C23426F.4020502@redhat.com>
On Thu, 24 Jun 2010 13:33:03 +0200, Phil Muldoon wrote:
> {
> struct value *val;
> struct value_print_options opts;
nitpick: I would prefer move val and opts to the inner TRY_CATCH block now.
[...]
> + TRY_CATCH (except, RETURN_MASK_ERROR)
> + {
> + val = read_var_value (var, frame);
> + get_user_print_options (&opts);
> + common_val_print (val, stream, indent, &opts, current_language);
> + }
> + if (except.reason < 0)
> + fprintf_filtered(stream, "<error reading variable %s (%s)>", name,
> + except.message);
Wrong indentation/formatting of the fprintf_filtered line.
Thanks,
Jan