This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] c++/11734


On 06/22/2010 08:43 AM, Keith Seitz wrote:
I noticed that I also missed adding this logic to the linear search
case. I've attached a revised patch which addresses this missed bit and
moves the alloca out of the loop.

BTW, after reviewing my own patch again, I think it should not break out of either loop prematurely: an exact match might later appear in the list.


While this doesn't really affect the ultimate outcome (because we know that symtabs will be searched next), prematurely breaking could cause lookup_partial_symbol to return NULL when an exact match is really found.

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]